Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: content/renderer/media/rtc_peer_connection_handler.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc
index e8ddec6e4f8b50f828d634d3a47c0fb834f4922e..171a38868b2963049303ccb57406f61a734b1c77 100644
--- a/content/renderer/media/rtc_peer_connection_handler.cc
+++ b/content/renderer/media/rtc_peer_connection_handler.cc
@@ -1159,11 +1159,13 @@ void RTCPeerConnectionHandler::setLocalDescription(
weak_factory_.GetWeakPtr(), peer_connection_tracker_,
PeerConnectionTracker::ACTION_SET_LOCAL_DESCRIPTION));
- signaling_thread()->PostTask(FROM_HERE,
- base::Bind(&RunClosureWithTrace,
+ signaling_thread()->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &RunClosureWithTrace,
base::Bind(&webrtc::PeerConnectionInterface::SetLocalDescription,
- native_peer_connection_, set_request,
- base::Unretained(native_desc)),
+ native_peer_connection_, base::RetainedRef(set_request),
+ base::Unretained(native_desc)),
"SetLocalDescription"));
}
@@ -1210,11 +1212,13 @@ void RTCPeerConnectionHandler::setRemoteDescription(
base::ThreadTaskRunnerHandle::Get(), request,
weak_factory_.GetWeakPtr(), peer_connection_tracker_,
PeerConnectionTracker::ACTION_SET_REMOTE_DESCRIPTION));
- signaling_thread()->PostTask(FROM_HERE,
- base::Bind(&RunClosureWithTrace,
+ signaling_thread()->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &RunClosureWithTrace,
base::Bind(&webrtc::PeerConnectionInterface::SetRemoteDescription,
- native_peer_connection_, set_request,
- base::Unretained(native_desc)),
+ native_peer_connection_, base::RetainedRef(set_request),
+ base::Unretained(native_desc)),
"SetRemoteDescription"));
}
« no previous file with comments | « content/renderer/gpu/gpu_benchmarking_extension.cc ('k') | content/renderer/service_worker/service_worker_context_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698