content/browser/service_worker/service_worker_version_unittest.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_version_unittest.cc

diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc

index 628d625f5f8f63e15ae77c7f18bfa5afb1da72d6..e47df282acf5ddcdb03eff471b659a8da82e7210 100644

--- a/content/browser/service_worker/service_worker_version_unittest.cc

+++ b/content/browser/service_worker/service_worker_version_unittest.cc

@@ -570,8 +570,8 @@ TEST_F(ServiceWorkerVersionTest, RepeatedlyObserveStatusChanges) {

// Repeatedly observe status changes (the callback re-registers itself).

std::vector<ServiceWorkerVersion::Status> statuses;

- version_->RegisterStatusChangeCallback(

- base::Bind(&ObserveStatusChanges, version_, &statuses));

+ version_->RegisterStatusChangeCallback(base::Bind(

+ &ObserveStatusChanges, base::RetainedRef(version_), &statuses));

version_->SetStatus(ServiceWorkerVersion::INSTALLING);

version_->SetStatus(ServiceWorkerVersion::INSTALLED);