content/browser/service_worker/service_worker_controllee_request_handler.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc

index c6089fc5d6605032269a97887e42e826977cad1f..8a285768e4f8cf8f867ef12aa7d01e5a5f46e31f 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc

+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc

@@ -233,11 +233,9 @@ ServiceWorkerControlleeRequestHandler::DidLookupRegistrationForMainResource(

if (active_version.get() &&

active_version->status() == ServiceWorkerVersion::ACTIVATING) {

provider_host_->SetAllowAssociation(false);

- registration->active_version()->RegisterStatusChangeCallback(

- base::Bind(&self::OnVersionStatusChanged,

- weak_factory_.GetWeakPtr(),

- registration,

- active_version));

+ registration->active_version()->RegisterStatusChangeCallback(base::Bind(

+ &self::OnVersionStatusChanged, weak_factory_.GetWeakPtr(),

+ base::RetainedRef(registration), base::RetainedRef(active_version)));

TRACE_EVENT_ASYNC_END2(

"ServiceWorker",

"ServiceWorkerControlleeRequestHandler::PrepareForMainResource",