Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: content/browser/loader/resource_loader_unittest.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_loader_unittest.cc
diff --git a/content/browser/loader/resource_loader_unittest.cc b/content/browser/loader/resource_loader_unittest.cc
index 8c8d7ba6ab7dd2d55c040c5fc1ecc1670e6e1926..56eac13df9f3ed0070e196f6d188181e827cd56f 100644
--- a/content/browser/loader/resource_loader_unittest.cc
+++ b/content/browser/loader/resource_loader_unittest.cc
@@ -167,7 +167,8 @@ class MockClientCertURLRequestJob : public net::URLRequestTestJob {
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::Bind(&MockClientCertURLRequestJob::NotifyCertificateRequested,
- weak_factory_.GetWeakPtr(), cert_request_info));
+ weak_factory_.GetWeakPtr(),
+ base::RetainedRef(cert_request_info)));
}
void ContinueWithCertificate(net::X509Certificate* cert,
@@ -532,7 +533,7 @@ void CreateTemporaryError(
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::Bind(callback, error, base::Passed(scoped_ptr<net::FileStream>()),
- scoped_refptr<ShareableFileReference>()));
+ nullptr));
}
} // namespace
@@ -919,8 +920,9 @@ class ResourceLoaderRedirectToFileTest : public ResourceLoaderTest {
scoped_ptr<net::FileStream> file_stream,
const CreateTemporaryFileStreamCallback& callback) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(callback, base::File::FILE_OK,
- base::Passed(&file_stream), deletable_file_));
+ FROM_HERE,
+ base::Bind(callback, base::File::FILE_OK, base::Passed(&file_stream),
+ base::RetainedRef(deletable_file_)));
}
base::FilePath temp_path_;

Powered by Google App Engine
This is Rietveld 408576698