components/bookmarks/browser/bookmark_storage.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_storage.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_storage.cc

diff --git a/components/bookmarks/browser/bookmark_storage.cc b/components/bookmarks/browser/bookmark_storage.cc

index f1c8380ba794a333c782a61477d93f29c810552a..3a184206cfb1db0dd44d5d85a6c970ffed9b5e7c 100644

--- a/components/bookmarks/browser/bookmark_storage.cc

+++ b/components/bookmarks/browser/bookmark_storage.cc

@@ -162,12 +162,10 @@ BookmarkStorage::~BookmarkStorage() {

void BookmarkStorage::LoadBookmarks(

scoped_ptr<BookmarkLoadDetails> details,

const scoped_refptr<base::SequencedTaskRunner>& task_runner) {

- sequenced_task_runner_->PostTask(FROM_HERE,

- base::Bind(&LoadCallback,

- writer_.path(),

- weak_factory_.GetWeakPtr(),

- base::Passed(&details),

- task_runner));

+ sequenced_task_runner_->PostTask(

+ FROM_HERE,

+ base::Bind(&LoadCallback, writer_.path(), weak_factory_.GetWeakPtr(),

+ base::Passed(&details), base::RetainedRef(task_runner)));

}

void BookmarkStorage::ScheduleSave() {