chrome/browser/extensions/extension_service.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 7d12152aaa8cee29918ad6d38aaed91d1ad5a458..018b5d67f65ca6d17bbc20944290d43685b1000c 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -1858,9 +1858,8 @@ void ExtensionService::AddNewOrUpdatedExtension(

const Extension* old = GetInstalledExtension(extension->id());

if (extensions::AppDataMigrator::NeedsMigration(old, extension)) {

app_data_migrator_->DoMigrationAndReply(

- old, extension,

- base::Bind(&ExtensionService::FinishInstallation, AsWeakPtr(),

- make_scoped_refptr(extension)));

+ old, extension, base::Bind(&ExtensionService::FinishInstallation,

+ AsWeakPtr(), base::RetainedRef(extension)));

return;

}