Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4936)

Unified Diff: chrome/browser/net/sdch_browsertest.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/sdch_browsertest.cc
diff --git a/chrome/browser/net/sdch_browsertest.cc b/chrome/browser/net/sdch_browsertest.cc
index 224c40049ce87374e5a1a8450b1bc2d9962a6833..0b7d40898e37b440981acacaf27bf078e1f6324b 100644
--- a/chrome/browser/net/sdch_browsertest.cc
+++ b/chrome/browser/net/sdch_browsertest.cc
@@ -420,7 +420,7 @@ class SdchBrowserTest : public InProcessBrowserTest,
content::BrowserThread::PostTaskAndReply(
content::BrowserThread::IO, FROM_HERE,
base::Bind(&SdchBrowserTest::NukeSdchDictionariesOnIOThread,
- url_request_context_getter_),
+ base::RetainedRef(url_request_context_getter_)),
run_loop.QuitClosure());
run_loop.Run();
}
@@ -449,11 +449,10 @@ class SdchBrowserTest : public InProcessBrowserTest,
second_browser_->window()->Show();
content::BrowserThread::PostTask(
- content::BrowserThread::IO,
- FROM_HERE,
+ content::BrowserThread::IO, FROM_HERE,
base::Bind(&SdchBrowserTest::SubscribeToSdchNotifications,
base::Unretained(this),
- make_scoped_refptr(
+ base::RetainedRef(
second_browser_->profile()->GetRequestContext())));
return true;
@@ -466,11 +465,10 @@ class SdchBrowserTest : public InProcessBrowserTest,
return false;
content::BrowserThread::PostTask(
- content::BrowserThread::IO,
- FROM_HERE,
+ content::BrowserThread::IO, FROM_HERE,
base::Bind(&SdchBrowserTest::SubscribeToSdchNotifications,
base::Unretained(this),
- make_scoped_refptr(
+ base::RetainedRef(
incognito_browser_->profile()->GetRequestContext())));
return true;
@@ -609,11 +607,10 @@ class SdchBrowserTest : public InProcessBrowserTest,
url_request_context_getter_ = browser()->profile()->GetRequestContext();
content::BrowserThread::PostTask(
- content::BrowserThread::IO,
- FROM_HERE,
+ content::BrowserThread::IO, FROM_HERE,
base::Bind(&SdchBrowserTest::SubscribeToSdchNotifications,
base::Unretained(this),
- url_request_context_getter_));
+ base::RetainedRef(url_request_context_getter_)));
}
void TearDownOnMainThread() override {

Powered by Google App Engine
This is Rietveld 408576698