chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/bind_helpers.h ('K') | « chrome/browser/media_galleries/fileapi/native_media_file_util.cc ('k') | chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc » ('j') | chrome/browser/printing/print_job_worker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.cc

diff --git a/chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.cc b/chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.cc

index 556e71b31ff4516f77bf935b28c5a76dc6410924..7f6843aad315335408e37936bf0ef6cb9ab093b8 100644

--- a/chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.cc

+++ b/chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.cc

@@ -105,11 +105,9 @@ void ReadaheadFileStreamReader::ReadFromSourceIfNeeded() {

scoped_refptr<net::IOBuffer> buf(new net::IOBuffer(kBufferSize));

int result = source_->Read(

- buf.get(),

- kBufferSize,

+ buf.get(), kBufferSize,

base::Bind(&ReadaheadFileStreamReader::OnFinishReadFromSource,

- weak_factory_.GetWeakPtr(),

- buf));

+ weak_factory_.GetWeakPtr(), base::RetainedRef(buf)));

if (result != net::ERR_IO_PENDING)

OnFinishReadFromSource(buf.get(), result);