Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1815313002: Use colors from color_palette.h (Closed)

Created:
4 years, 9 months ago by shrike
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use colors from color_palette.h This button hardcodes colors that appear in color_palette.h - not good (though I only became aware of that header after working on the class). BUG=596135 Committed: https://crrev.com/3d56cbf38e2e9791c43fb313d7ad200cd031ca61 Cr-Commit-Position: refs/heads/master@{#382085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
shrike
PTAL
4 years, 9 months ago (2016-03-18 18:55:21 UTC) #3
Avi (use Gerrit)
lgtm That's an interesting file!
4 years, 9 months ago (2016-03-18 18:57:21 UTC) #4
shrike
On 2016/03/18 18:57:21, Avi wrote: > lgtm > > That's an interesting file! Yes! And ...
4 years, 9 months ago (2016-03-18 19:02:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815313002/1
4 years, 9 months ago (2016-03-18 19:02:58 UTC) #7
Avi (use Gerrit)
On 2016/03/18 19:02:31, shrike wrote: > On 2016/03/18 18:57:21, Avi wrote: > > lgtm > ...
4 years, 9 months ago (2016-03-18 19:07:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 21:08:14 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 21:09:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d56cbf38e2e9791c43fb313d7ad200cd031ca61
Cr-Commit-Position: refs/heads/master@{#382085}

Powered by Google App Engine
This is Rietveld 408576698