Chromium Code Reviews
DescriptionRevert of Skip PaintLayer empty paint phases if it previously painted nothing (patchset #12 id:220001 of https://codereview.chromium.org/1739893006/ )
Reason for revert:
BUG=595839
Original issue's description:
> Skip PaintLayer empty paint phases if it previously painted nothing
>
> This avoids later painting of empty phases if the layer is marked to need
> a paint phase but the phase painted nothing in the following cases:
> - the object marking the layer needing the paint phase is not visible
> (e.g. because it is clipped)
> - the layer was marked needing the paint phase by some object that
> has been deleted or moved to another layer.
>
> Instead of directly clearing the needsPaintPhase flags, this CL adds
> a new set of flags to indicate if the previous paint of the phases painted
> nothing. This is because invalidations of the needsPaintPhase flags and the
> new flags need different conditions. The new flags are cleared when scroll
> offset, interest rect or clipping changes.
>
> Cluster telemetry runs show that this will improve non-cached painting
> by 1.7% and fully-cached painting (with subsequence-caching disabled) by
> 45%.
>
> BUG=574938
>
> Committed: https://crrev.com/8ad6e62af5301a7e8dacd12fc1ae7914258b9e7a
> Cr-Commit-Position: refs/heads/master@{#380841}
TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=574938
Committed: https://crrev.com/e425e3a8c5204d2d75f34c885c33f077372d1ff8
Cr-Commit-Position: refs/heads/master@{#382018}
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 12 (4 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||