Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1815293002: Revert of Skip PaintLayer empty paint phases if it previously painted nothing (Closed)

Created:
4 years, 9 months ago by Xianzhu
Modified:
4 years, 9 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Skip PaintLayer empty paint phases if it previously painted nothing (patchset #12 id:220001 of https://codereview.chromium.org/1739893006/ ) Reason for revert: BUG=595839 Original issue's description: > Skip PaintLayer empty paint phases if it previously painted nothing > > This avoids later painting of empty phases if the layer is marked to need > a paint phase but the phase painted nothing in the following cases: > - the object marking the layer needing the paint phase is not visible > (e.g. because it is clipped) > - the layer was marked needing the paint phase by some object that > has been deleted or moved to another layer. > > Instead of directly clearing the needsPaintPhase flags, this CL adds > a new set of flags to indicate if the previous paint of the phases painted > nothing. This is because invalidations of the needsPaintPhase flags and the > new flags need different conditions. The new flags are cleared when scroll > offset, interest rect or clipping changes. > > Cluster telemetry runs show that this will improve non-cached painting > by 1.7% and fully-cached painting (with subsequence-caching disabled) by > 45%. > > BUG=574938 > > Committed: https://crrev.com/8ad6e62af5301a7e8dacd12fc1ae7914258b9e7a > Cr-Commit-Position: refs/heads/master@{#380841} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=574938 Committed: https://crrev.com/e425e3a8c5204d2d75f34c885c33f077372d1ff8 Cr-Commit-Position: refs/heads/master@{#382018}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -107 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 2 chunks +7 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 3 chunks +8 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/core/paint/README.md View 1 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Xianzhu
Created Revert of Skip PaintLayer empty paint phases if it previously painted nothing
4 years, 9 months ago (2016-03-18 17:02:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815293002/1
4 years, 9 months ago (2016-03-18 17:02:53 UTC) #2
chrishtr
lgtm
4 years, 9 months ago (2016-03-18 17:04:32 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/6385) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-18 17:04:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815293002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815293002/140001
4 years, 9 months ago (2016-03-18 17:16:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:140001)
4 years, 9 months ago (2016-03-18 18:25:03 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e425e3a8c5204d2d75f34c885c33f077372d1ff8 Cr-Commit-Position: refs/heads/master@{#382018}
4 years, 9 months ago (2016-03-18 18:26:15 UTC) #11
Xianzhu
4 years, 3 months ago (2016-08-26 22:17:06 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:140001) has been created in
https://codereview.chromium.org/2285633005/ by wangxianzhu@chromium.org.

The reason for reverting is: Create a reland CL for debugging..

Powered by Google App Engine
This is Rietveld 408576698