Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Issue 1815253002: Fix another unguarded cast to an impl class (issue 26034, case 2) (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix another unguarded cast to an impl class (issue 26034, case 2) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/05a72c6df19723cc40ce6dfad4dc42af20f851c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-18 16:50:32 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-18 16:52:41 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-03-18 16:55:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
05a72c6df19723cc40ce6dfad4dc42af20f851c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698