Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 181523002: ARM Skia NEON patches - 22 - S32_D565_Blend (Closed)

Created:
6 years, 10 months ago by kevin.petit
Modified:
6 years, 8 months ago
Reviewers:
djsollen, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

ARM Skia NEON patches - 22 - S32_D565_Blend BlitRow565: new NEON version of S32_D565_Blend This new implementation brings a good speedup in most cases and gives exact results (removes one mismatch in gm). Here are the benchmark results (speedup vs. existing S32A_D565_Blend): +-------+-----------+------------+ | count | Cortex-A9 | Cortex-A15 | +-------+-----------+------------+ | 1 | -26,7% | -27,5% | +-------+-----------+------------+ | 2 | 0% | +53% | +-------+-----------+------------+ | 4 | +38,3% | +26,5% | +-------+-----------+------------+ | 8 | +10,9% | -4,5% | +-------+-----------+------------+ | 16 | +18,2% | +1,6% | +-------+-----------+------------+ | 64 | +22,3% | +8,75% | +-------+-----------+------------+ | 256 | +12,3% | +11,2% | +-------+-----------+------------+ | 1024 | +79,2% | +10,9% | +-------+-----------+------------+ Signed-off-by: Kévin PETIT <kevin.petit@arm.com>; BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14103

Patch Set 1 #

Patch Set 2 : Add ignored-tests.txt #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -4 lines) Patch
expectations/gm/ignored-tests.txt View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 2 chunks +85 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kevin.petit
6 years, 10 months ago (2014-02-26 14:42:49 UTC) #1
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 10 months ago (2014-02-26 14:49:43 UTC) #2
djsollen
The CQ bit was unchecked by djsollen@google.com
6 years, 10 months ago (2014-02-26 14:49:44 UTC) #3
kevin.petit
ping. I've uploaded a rebased version.
6 years, 9 months ago (2014-03-11 15:42:10 UTC) #4
kevin.petit
ping. I've uploaded a rebased version which will apply until the next modification to ignored-tests.txt.
6 years, 8 months ago (2014-04-08 14:47:28 UTC) #5
djsollen
lgtm
6 years, 8 months ago (2014-04-08 20:25:01 UTC) #6
kevin.petit
The CQ bit was checked by kevin.petit@arm.com
6 years, 8 months ago (2014-04-09 09:29:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/181523002/60001
6 years, 8 months ago (2014-04-09 09:29:55 UTC) #8
commit-bot: I haz the power
Change committed as 14103
6 years, 8 months ago (2014-04-09 09:46:46 UTC) #9
djsollen
On 2014/04/09 09:46:46, I haz the power (commit-bot) wrote: > Change committed as 14103 Do ...
6 years, 8 months ago (2014-04-09 13:16:57 UTC) #10
kevin.petit
On 2014/04/09 13:16:57, djsollen wrote: > On 2014/04/09 09:46:46, I haz the power (commit-bot) wrote: ...
6 years, 8 months ago (2014-04-09 13:18:46 UTC) #11
kevin.petit
6 years, 8 months ago (2014-04-09 13:42:43 UTC) #12
Message was sent while issue was closed.
On 2014/04/09 13:18:46, kevin.petit wrote:
> On 2014/04/09 13:16:57, djsollen wrote:
> > On 2014/04/09 09:46:46, I haz the power (commit-bot) wrote:
> > > Change committed as 14103
> > 
> > Do you want to upload the rebaseline CL or should I?  Also there are 2 GPU
> > gradients_view_perspective GMs that are marked as ignore failure.  If you do
> the
> > rebaseline make sure to only pickup the 565 changes and not those as well.
> 
> Ok, I'm on it.

Rebaselines: https://codereview.chromium.org/230733004/

Powered by Google App Engine
This is Rietveld 408576698