Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Issue 1815183002: [Layout API] Add LayoutItem.isBR() and use from editing/VisibleUnits (Closed)

Created:
4 years, 9 months ago by pilgrim_google
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, dgrogan, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Add LayoutItem.isBR() and use from editing/VisibleUnits As far as I can tell, we don't need a whole LayoutBRItem class to proxy specific methods from LayoutBR, but we do need an isBR() method on the ancestor LayoutItem so we can call it from places that currently call LayoutObject*->isBR(). One example of this is in editing/VisibleUnits. There are no functional changes. BUG=499321 TBR=leviw@chromium.org Committed: https://crrev.com/943ae70d508af56a2aaafeaf855e7f0e6c717403 Cr-Commit-Position: refs/heads/master@{#381970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pilgrim_google
4 years, 9 months ago (2016-03-18 14:02:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815183002/1
4 years, 9 months ago (2016-03-18 14:02:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 15:09:28 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 15:11:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/943ae70d508af56a2aaafeaf855e7f0e6c717403
Cr-Commit-Position: refs/heads/master@{#381970}

Powered by Google App Engine
This is Rietveld 408576698