Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1815163003: Fix BidirectionalStreamTest#testFailures flake (Closed)

Created:
4 years, 9 months ago by xunjieli
Modified:
4 years, 9 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BidirectionalStreamTest#testFailures flake Cancel during ResponseStep.ON_REQEST_HEADERS_SENT does not guarantee that mResponseInfo will be null, because an onResponseHeadersReceived callback might already been queued at the executor. BUG=594432 Committed: https://crrev.com/3954c975719d59922ccc6e5935e74748bf63e8e7 Cr-Commit-Position: refs/heads/master@{#382444}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java View 1 3 chunks +24 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
xunjieli
4 years, 9 months ago (2016-03-18 15:22:28 UTC) #2
mef
https://codereview.chromium.org/1815163003/diff/1/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java File components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java (right): https://codereview.chromium.org/1815163003/diff/1/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java#newcode815 components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java:815: boolean expectResponseInfo, boolean expectError) { remove |expectResponseInfo|.
4 years, 9 months ago (2016-03-18 15:30:18 UTC) #3
xunjieli
Thanks! https://codereview.chromium.org/1815163003/diff/1/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java File components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java (right): https://codereview.chromium.org/1815163003/diff/1/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java#newcode815 components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java:815: boolean expectResponseInfo, boolean expectError) { On 2016/03/18 15:30:18, ...
4 years, 9 months ago (2016-03-18 15:39:47 UTC) #4
mef
lgtm
4 years, 9 months ago (2016-03-21 22:37:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815163003/20001
4 years, 9 months ago (2016-03-21 23:03:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 00:00:50 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 00:01:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3954c975719d59922ccc6e5935e74748bf63e8e7
Cr-Commit-Position: refs/heads/master@{#382444}

Powered by Google App Engine
This is Rietveld 408576698