Introduce EmbedderHeapTracer

src/heap/heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/heap/heap.h"
 
 #include "src/accessors.h"
 #include "src/api.h"
 #include "src/ast/scopeinfo.h"
 #include "src/base/bits.h"
@@ skipping 98 matching lines @@
       remembered_unmapped_pages_index_(0),
 #ifdef DEBUG
       allocation_timeout_(0),
 #endif  // DEBUG
       old_generation_allocation_limit_(initial_old_generation_size_),
       old_gen_exhausted_(false),
       optimize_for_memory_usage_(false),
       inline_allocation_disabled_(false),
       total_regexp_code_generated_(0),
       tracer_(nullptr),
+      embedder_heap_tracer_(nullptr),
       high_survival_rate_period_length_(0),
       promoted_objects_size_(0),
       promotion_ratio_(0),
       semi_space_copied_object_size_(0),
       previous_semi_space_copied_object_size_(0),
       semi_space_copied_rate_(0),
       nodes_died_in_new_space_(0),
       nodes_copied_in_new_space_(0),
       nodes_promoted_(0),
       maximum_size_scavenges_(0),
@@ skipping 5284 matching lines @@
 #ifdef DEBUG
   // All pages right after bootstrapping must be marked as never-evacuate.
   PagedSpaces spaces(this);
   for (PagedSpace* s = spaces.next(); s != NULL; s = spaces.next()) {
     PageIterator it(s);
     while (it.has_next()) CHECK(it.next()->NeverEvacuate());
   }
 #endif  // DEBUG
 }
 
+void Heap::AddObjectToMarkingDeque(Object** object) {
+  DCHECK(incremental_marking()->IsMarking());
+  HeapObject* heap_object = HeapObject::cast(*object);
+  IncrementalMarking::MarkObject(isolate()->heap(), heap_object);

[jochen (gone - plz use gerrit), 2016/03/30 16:46:17]

isolate()->heap() === this

[Marcel Hlopko, 2016/03/30 18:51:12]

In the meantime I fixed a bug, ptal at new version

+}
 
 void Heap::TearDown() {
 #ifdef VERIFY_HEAP
   if (FLAG_verify_heap) {
     Verify();
   }
 #endif
 
   UpdateMaximumCommitted();
 
@@ skipping 145 matching lines @@
   DCHECK(callback != NULL);
   for (int i = 0; i < gc_epilogue_callbacks_.length(); ++i) {
     if (gc_epilogue_callbacks_[i].callback == callback) {
       gc_epilogue_callbacks_.Remove(i);
       return;
     }
   }
   UNREACHABLE();
 }
 
+void Heap::SetEmbedderHeapTracer(EmbedderHeapTracer* tracer) {
+  DCHECK(tracer != nullptr);

[jochen (gone - plz use gerrit), 2016/03/30 16:46:17]

DCHECK_NOT_NULL()

I'd also add CHECK_NULL(embedder_heap_tracer_)

[Marcel Hlopko, 2016/03/30 18:51:12]

Done.

+  embedder_heap_tracer_ = tracer;
+}
 
 // TODO(ishell): Find a better place for this.
 void Heap::AddWeakObjectToCodeDependency(Handle<HeapObject> obj,
                                          Handle<DependentCode> dep) {
   DCHECK(!InNewSpace(*obj));
   DCHECK(!InNewSpace(*dep));
   Handle<WeakHashTable> table(weak_object_to_code_table(), isolate());
   table = WeakHashTable::Put(table, obj, dep);
   if (*table != weak_object_to_code_table())
     set_weak_object_to_code_table(*table);
@@ skipping 875 matching lines @@
 }
 
 
 // static
 int Heap::GetStaticVisitorIdForMap(Map* map) {
   return StaticVisitorBase::GetVisitorId(map);
 }
 
 }  // namespace internal
 }  // namespace v8