third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp - Issue 1815093002: Canvas2d: fix event.region being null on mouseleave/out events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Issue 1815093002: Canvas2d: fix event.region being null on mouseleave/out events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

index 7b841c4885ff8c1ef35bda30d6a0358afce6109d..d5b5ebd87509307b91ec0ba53ead5768617d9f22 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

@@ -605,6 +605,16 @@ std::pair<Element*, String> CanvasRenderingContext2D::getControlAndIdIfHitRegion

return std::make_pair(nullptr, String());

}

+String CanvasRenderingContext2D::getIdFromControl(const Element* element)

+ if (hitRegionsCount() <= 0)

+ return String();

+ if (HitRegion* hitRegion = m_hitRegionManager->getHitRegionByControl(const_cast<Element*>(element)))

+ return hitRegion->id();

+ return String();

String CanvasRenderingContext2D::textAlign() const

{

return textAlignName(state().getTextAlign());