Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-event-test.html

Issue 1815093002: Canvas2d: fix event.region being null on mouseleave/out events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-event-test.html
diff --git a/third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-event-test.html b/third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-event-test.html
index d970e7857abe97f2ed0ab2d10c0b72a8bfea84b7..307e73848616aa3e979c4cfcb1feb32b43979fc4 100644
--- a/third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-event-test.html
+++ b/third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-event-test.html
@@ -109,10 +109,8 @@ async_test(function() {
{ type: 'mousemove', target: button, region: 'button' },
{ type: 'mousedown', target: button, region: 'button' },
{ type: 'mouseup', target: button, region: 'button' },
- // TODO(zino): The expected value of region should be "button" instead of
- // null in case of mouseout/mouseleave. Please see http://crbug.com/592992.
- { type: 'mouseout', target: button, region: null },
- { type: 'mouseleave', target: button, region: null },
+ { type: 'mouseout', target: button, region: 'button' },
+ { type: 'mouseleave', target: button, region: 'button' },
{ type: 'touchstart', target: button, region: 'button' },
{ type: 'touchend', target: button, region: 'button' },
];

Powered by Google App Engine
This is Rietveld 408576698