Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: third_party/WebKit/Source/core/style/BorderValue.h

Issue 1815043003: CSS border-image spec compliance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/BorderValue.h
diff --git a/third_party/WebKit/Source/core/style/BorderValue.h b/third_party/WebKit/Source/core/style/BorderValue.h
index 7914be917c72d9f3382fe6942b8ad5a0ba28d0bb..a88fa1f3a99b1cb1254c4b776ec7dd9b69d2e303 100644
--- a/third_party/WebKit/Source/core/style/BorderValue.h
+++ b/third_party/WebKit/Source/core/style/BorderValue.h
@@ -45,9 +45,9 @@ public:
{
}
- bool nonZero(bool checkStyle = true) const
+ bool nonZero() const
{
- return width() && (!checkStyle || m_style != BorderStyleNone);
+ return width() && (m_style != BorderStyleNone);
}
bool isTransparent() const
@@ -55,9 +55,9 @@ public:
return !m_colorIsCurrentColor && !m_color.alpha();
}
- bool isVisible(bool checkStyle = true) const
+ bool isVisible() const
{
- return nonZero(checkStyle) && !isTransparent() && (!checkStyle || m_style != BorderStyleHidden);
+ return nonZero() && !isTransparent() && (m_style != BorderStyleHidden);
}
alancutter (OOO until 2018) 2016/03/18 01:46:33 Does anyone call this? Perhaps it should be delete
cavalcantii1 2016/03/18 02:01:29 It seems that isVisible() is dead code. I will rem
bool operator==(const BorderValue& o) const

Powered by Google App Engine
This is Rietveld 408576698