CSS border-image spec compliance

CSS border-image spec compliance

Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to deprecate and remove:
https://goo.gl/SVS8kd

BUG=559258
Committed: https://crrev.com/db8a8b23bfce3adeb9566da47cd724899d8d5b32
Cr-Commit-Position: refs/heads/master@{#382207}

[cavalcantii1, 2016-03-18 01:01:08]

cavalcantii@chromium.org changed reviewers:
+ alancutter@chromium.org, rbyers@chromium.org

[cavalcantii1, 2016-03-18 01:01:08]

FYI.

[alancutter (OOO until 2018), 2016-03-18 01:46:33]

The description should link to the blink-dev thread proposing this change.

https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/TestExpectations:141: crbug.com/559258
svg/as-border-image/svg-as-border-image.html [ NeedsRebaseline ]
I thought tests had been updated to not depend on the non-standard border-image
behaviour. What is changing here?

https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/BorderValue.h (right):

https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/BorderValue.h:61: }
Does anyone call this? Perhaps it should be deleted.

[cavalcantii1, 2016-03-18 01:57:24]

On 2016/03/18 01:46:33, alancutter wrote:
> The description should link to the blink-dev thread proposing this change.
> 
>
https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/TestExpectations:141: crbug.com/559258
> svg/as-border-image/svg-as-border-image.html [ NeedsRebaseline ]
> I thought tests had been updated to not depend on the non-standard
border-image
> behaviour. What is changing here?
> 

When I wrote this patch way back in November, I recall that the dump render tree
would be 'border-style: none' and after the changes on the tests, 'border-style:
solid'. That should be ok.

That being said, there might be minor differences in pixel results that would
require a rebaseline.

I can upload a patch without it and we see how bots will behave.

>
https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/style/BorderValue.h (right):
> 
>
https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/style/BorderValue.h:61: }
> Does anyone call this? Perhaps it should be deleted.

I can test it.

[cavalcantii1, 2016-03-18 02:01:29]

https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/BorderValue.h (right):

https://codereview.chromium.org/1815043003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/BorderValue.h:61: }
It seems that isVisible() is dead code. I will remove it.

[cavalcantii1, 2016-03-18 02:24:25]

Description was changed from

==========
Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Relevant spec:
http://www.w3.org/TR/css3-background/#border-images

BUG=559258
==========

to

==========
Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to implement:
https://goo.gl/SVS8kd

BUG=559258
==========

[Rick Byers, 2016-03-18 02:39:04]

Description was changed from

==========
Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to implement:
https://goo.gl/SVS8kd

BUG=559258
==========

to

==========
Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to implement and ship:
https://goo.gl/SVS8kd

BUG=559258
==========

[Rick Byers, 2016-03-18 02:39:58]

Description was changed from

==========
Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to implement and ship:
https://goo.gl/SVS8kd

BUG=559258
==========

to

==========
CSS border-image spec compliance

Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to implement and ship:
https://goo.gl/SVS8kd

BUG=559258
==========

[Rick Byers, 2016-03-18 02:42:19]

Description was changed from

==========
CSS border-image spec compliance

Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to implement and ship:
https://goo.gl/SVS8kd

BUG=559258
==========

to

==========
CSS border-image spec compliance

Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to deprecate and remove:
https://goo.gl/SVS8kd

BUG=559258
==========

[Rick Byers, 2016-03-18 02:44:13]

I tweaked the CL description slightly (added a one-line summary for the benefit
of git, and called it an intent to deprecate and remove, since we updated it to
follow that pattern).

The deprecation warning code can also be removed now, but I'm fine with putting
that off to a later CL if you prefer.

[cavalcantii1, 2016-03-18 06:22:37]

Rick

Thanks for updating the description.

As soon we land this, I can submit another CL to remove the deprecation warning.

[Rick Byers, 2016-03-18 18:17:52]

Thanks, LGTM (but please also wait for Alan since he's the style expert).

[cavalcantii1, 2016-03-18 18:19:51]

I'm investigating the red bots as there a couple tests failing.

[cavalcantii1, 2016-03-18 19:16:19]

This should also fix issue reported on:
https://codereview.chromium.org/1784753003/

[Rick Byers, 2016-03-18 19:21:14]

Looks good, thanks.

https://codereview.chromium.org/1815043003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/scrollbars/listbox-scrollbar-combinations.html
(right):

https://codereview.chromium.org/1815043003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/scrollbars/listbox-scrollbar-combinations.html:150:
border-style: solid;
nit: remove dupe

[alancutter (OOO until 2018), 2016-03-19 07:45:18]

lgtm

[cavalcantii1, 2016-03-19 22:10:46]

The CQ bit was checked by cavalcantii@chromium.org

[cavalcantii1, 2016-03-19 22:10:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1815043003/#ps80001
(title: "Removing duplicated.")

[commit-bot: I haz the power, 2016-03-19 22:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815043003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815043003/80001

[commit-bot: I haz the power, 2016-03-20 01:02:13]

Description was changed from

==========
CSS border-image spec compliance

Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to deprecate and remove:
https://goo.gl/SVS8kd

BUG=559258
==========

to

==========
CSS border-image spec compliance

Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to deprecate and remove:
https://goo.gl/SVS8kd

BUG=559258
==========

[commit-bot: I haz the power, 2016-03-20 01:02:14]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-20 01:03:27]

Description was changed from

==========
CSS border-image spec compliance

Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to deprecate and remove:
https://goo.gl/SVS8kd

BUG=559258
==========

to

==========
CSS border-image spec compliance

Enforce compliance to css-background spec, where an element
will only have its border displayed if a border-style
is defined (even when border-image property is set).

Intent to deprecate and remove:
https://goo.gl/SVS8kd

BUG=559258

Committed: https://crrev.com/db8a8b23bfce3adeb9566da47cd724899d8d5b32
Cr-Commit-Position: refs/heads/master@{#382207}
==========

[commit-bot: I haz the power, 2016-03-20 01:03:28]

Patchset 5 (id:??) landed as
https://crrev.com/db8a8b23bfce3adeb9566da47cd724899d8d5b32
Cr-Commit-Position: refs/heads/master@{#382207}