Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1815033004: Disable WebView CTS WebChromeClientTest#testOnJsBeforeUnload (Closed)

Created:
4 years, 9 months ago by hush (inactive)
Modified:
4 years, 9 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Disable WebView CTS WebChromeClientTest#testOnJsBeforeUnload This CTS test used a blink feature to customize the unload message. This feature has been removed by blink. As a result, this test will fail permanently. We plan to remove this CTS test from future CTS publishes. BUG=594573 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hush (inactive)
Hello martiniss, PTAL
4 years, 9 months ago (2016-03-18 21:04:49 UTC) #2
martiniss
lgtm
4 years, 9 months ago (2016-03-18 21:13:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815033004/1
4 years, 9 months ago (2016-03-18 21:14:39 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 21:18:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299391

Powered by Google App Engine
This is Rietveld 408576698