Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1966)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1815033003: Add srcObject attribute of type MediaStream to HTMLMediaElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: philipj's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 9426ed14004d3eaf9781378f324e80259e8f3a4a..ab1a48f4ba0af1b461306af855aad1ac3d0230a4 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -102,6 +102,7 @@
#include "content/renderer/media/render_media_log.h"
#include "content/renderer/media/renderer_webmediaplayer_delegate.h"
#include "content/renderer/media/user_media_client_impl.h"
+#include "content/renderer/media/web_media_element_source_utils.h"
#include "content/renderer/media/webmediaplayer_ms.h"
#include "content/renderer/mojo/service_registry_js_wrapper.h"
#include "content/renderer/mojo_bindings_controller.h"
@@ -150,6 +151,7 @@
#include "third_party/WebKit/public/platform/URLConversion.h"
#include "third_party/WebKit/public/platform/WebData.h"
#include "third_party/WebKit/public/platform/WebMediaPlayer.h"
+#include "third_party/WebKit/public/platform/WebMediaPlayerSource.h"
#include "third_party/WebKit/public/platform/WebSecurityOrigin.h"
#include "third_party/WebKit/public/platform/WebStorageQuotaCallbacks.h"
#include "third_party/WebKit/public/platform/WebString.h"
@@ -2403,7 +2405,7 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(
}
blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
- const blink::WebURL& url,
+ const blink::WebMediaPlayerSource& source,
WebMediaPlayerClient* client,
WebMediaPlayerEncryptedMediaClient* encrypted_client,
WebContentDecryptionModule* initial_cdm,
@@ -2415,13 +2417,17 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
contains_media_player_ = true;
}
#endif // defined(VIDEO_HOLE)
-
- blink::WebMediaStream web_stream(
- blink::WebMediaStreamRegistry::lookupMediaStreamDescriptor(url));
+ blink::WebMediaStream web_stream =
+ GetWebMediaStreamFromWebMediaPlayerSource(source);
if (!web_stream.isNull())
return CreateWebMediaPlayerForMediaStream(client, sink_id,
frame_->getSecurityOrigin());
+ // If |source| was not a MediaStream, it must be a URL.
+ // TODO(guidou): Fix this when support for other srcObject types is added.
+ DCHECK(source.isURL());
+ blink::WebURL url = source.getAsURL();
+
RenderThreadImpl* render_thread = RenderThreadImpl::current();
scoped_refptr<media::SwitchableAudioRendererSink> audio_renderer_sink =

Powered by Google App Engine
This is Rietveld 408576698