third_party/WebKit/Source/modules/mediastream/HTMLMediaElementMediaStream.idl - Issue 1815033003: Add srcObject attribute of type MediaStream to HTMLMediaElement.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/HTMLMediaElementMediaStream.idl

Issue 1815033003: Add srcObject attribute of type MediaStream to HTMLMediaElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix listing tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/mediastream/HTMLMediaElementMediaStream.cpp ('K') | « third_party/WebKit/Source/modules/mediastream/HTMLMediaElementMediaStream.cpp ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://html.spec.whatwg.org/multipage/embedded-content.html#dom-media-srcobj ect

	6

	7 [

	8 RuntimeEnabled=SrcObject

	9 ] partial interface HTMLMediaElement {
	haraken 2016/03/18 23:37:40 Would you add: // TODO(haraken): Per the spec, Would you add: // TODO(haraken): Per the spec, the srcObject should be defined in HTMLMediaElement.idl. However, we cannot define srcObject in HTMLMediaElement.idl because of the dependency restriction from modules/ to core/. For now we avoid the problem by using a partial interface. Guido Urdaneta 2016/03/20 12:16:30 Done. Show quoted text On 2016/03/18 23:37:40, haraken wrote: > > Would you add: > > // TODO(haraken): Per the spec, the srcObject should be defined in > HTMLMediaElement.idl. However, we cannot define srcObject in > HTMLMediaElement.idl because of the dependency restriction from modules/ to > core/. For now we avoid the problem by using a partial interface. Done.
	10 attribute MediaStream? srcObject;
	haraken 2016/03/18 23:37:40 The spec says that the type is MediaProvider?. Is The spec says that the type is MediaProvider?. Is it okay to use MediaStream? ? Guido Urdaneta 2016/03/20 12:16:30 Now using MediaProvider, which is typedef'ed to be Show quoted text On 2016/03/18 23:37:40, haraken wrote: > > The spec says that the type is MediaProvider?. Is it okay to use MediaStream? ? Now using MediaProvider, which is typedef'ed to be MediaStream for now. According to the spec, it can be MediaStream, MediaSource or Blob. For now we support only MediaStream, but added a TODO to support the other types mentioned in the spec. As I explain in the I2I, supporting MediaStream puts us at the same level of support of all the other major browsers.
	11 };

OLD	NEW