third_party/WebKit/LayoutTests/media/video-srcobject-mediastream.html - Issue 1815033003: Add srcObject attribute of type MediaStream to HTMLMediaElement.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-srcobject-mediastream.html

Issue 1815033003: Add srcObject attribute of type MediaStream to HTMLMediaElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android and tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | third_party/WebKit/LayoutTests/media/video-srcobject-mediastream-src-file.html » ('j') | third_party/WebKit/LayoutTests/media/video-srcobject-mediastream-src-file.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <title>Test assignment of a MediaStream via the srcObject attribute.</title>

	3 <video autoplay></video>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script>

	7 var video = document.querySelector("video")

	8

	9 var test = async_test(test => {
	philipj_slow 2016/04/07 15:38:11 This looks a bit unusual, if you just move playing This looks a bit unusual, if you just move playingSrcObject into the inner function you won't need the return value, and you can move the video variable in as well. Guido Urdaneta 2016/04/08 10:58:47 Done. Show quoted text On 2016/04/07 15:38:11, philipj wrote: > This looks a bit unusual, if you just move playingSrcObject into the inner > function you won't need the return value, and you can move the video variable in > as well. Done.
	10 assert_idl_attribute(video, "srcObject");

	11 assert_equals(video.srcObject, null);

	12 assert_equals(video.currentSrc, "");

	13 navigator.webkitGetUserMedia(

	14 {video:true},

	15 test.step_func(stream => {

	16 video.addEventListener("playing", test.step_func(playingSrcObject) );

	17 video.srcObject = stream;

	18 }),

	19 test.unreached_func("Did not get mediastream"));

	20 })

	21

	22 function playingSrcObject()

	23 {

	24 video.addEventListener("emptied", test.step_func_done(_ => {

	25 assert_equals(video.srcObject, null);

	26 assert_equals(video.currentSrc, "");

	27 }));

	28 assert_not_equals(video.srcObject, null);

	29 assert_class_string(video.srcObject, "MediaStream");

	30 assert_equals(video.currentSrc, "");

	31 video.srcObject = null;

	32 }

	33 </script>

OLD	NEW