Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1815033002: Pass legacy const runtime flag to preparser appropriately (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass legacy const runtime flag to preparser appropriately It was never being set to false in production (though it was in test-parsing.cc, due to that test having its own flag-setting logic). Committed: https://crrev.com/2c9e38e09e42e95e2ed9760f556add4f7693d2a7 Cr-Commit-Position: refs/heads/master@{#34878}

Patch Set 1 #

Patch Set 2 : Now with tests #

Patch Set 3 : Remove useless webkit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/message/const-decl-no-init-sloppy.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + test/message/const-decl-no-init-sloppy.out View 1 1 chunk +4 lines, -5 lines 0 comments Download
M test/webkit/fast/js/arguments.js View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M test/webkit/fast/js/arguments-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
adamk
4 years, 9 months ago (2016-03-18 00:05:04 UTC) #2
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-18 00:05:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815033002/20001
4 years, 9 months ago (2016-03-18 00:05:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15430)
4 years, 9 months ago (2016-03-18 00:21:09 UTC) #7
adamk
Fixed trybots by simply removing one line from an old webkit tests. We already failed ...
4 years, 9 months ago (2016-03-18 00:46:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815033002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815033002/40001
4 years, 9 months ago (2016-03-18 01:07:05 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-18 01:09:06 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 01:09:24 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2c9e38e09e42e95e2ed9760f556add4f7693d2a7
Cr-Commit-Position: refs/heads/master@{#34878}

Powered by Google App Engine
This is Rietveld 408576698