Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 181503009: Rename BaseNativeAppWindowViews and NativeAppWindowViews (Closed)

Created:
6 years, 10 months ago by James Cook
Modified:
6 years, 9 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Rename BaseNativeAppWindowViews and NativeAppWindowViews * NativeAppWindowViewsWin -> ChromeNativeAppWindowViewsWin * NativeAppWindowViews -> ChromeNativeAppWindowViews * BaseNativeAppWindowViews -> apps::NativeAppWindowViews BUG=345909 TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253914

Patch Set 1 #

Patch Set 2 : namespace apps (native_app_window) #

Patch Set 3 : rebase (native_app_window) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -1872 lines) Patch
M apps/apps.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M apps/shell/browser/shell_app_window_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D apps/ui/views/base_native_app_window_views.h View 1 chunk +0 lines, -185 lines 0 comments Download
D apps/ui/views/base_native_app_window_views.cc View 1 chunk +0 lines, -413 lines 0 comments Download
A + apps/ui/views/native_app_window_views.h View 1 6 chunks +24 lines, -23 lines 0 comments Download
A + apps/ui/views/native_app_window_views.cc View 1 15 chunks +89 lines, -91 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_app_window_delegate_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_app_window_delegate_views_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/views/apps/chrome_native_app_window_views.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 2 17 chunks +30 lines, -30 lines 0 comments Download
A + chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 6 chunks +17 lines, -17 lines 0 comments Download
D chrome/browser/ui/views/apps/native_app_window_views.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/ui/views/apps/native_app_window_views.cc View 1 2 1 chunk +0 lines, -682 lines 0 comments Download
D chrome/browser/ui/views/apps/native_app_window_views_win.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/views/apps/native_app_window_views_win.cc View 1 chunk +0 lines, -221 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
James Cook
benwells, PTAL
6 years, 10 months ago (2014-02-27 01:05:36 UTC) #1
benwells
lgtm
6 years, 10 months ago (2014-02-27 02:33:32 UTC) #2
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 10 months ago (2014-02-27 05:31:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/181503009/20001
6 years, 10 months ago (2014-02-27 05:31:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 07:28:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=271217
6 years, 9 months ago (2014-02-27 07:28:24 UTC) #6
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-02-27 17:13:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/181503009/40001
6 years, 9 months ago (2014-02-27 17:13:15 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 20:08:59 UTC) #9
Message was sent while issue was closed.
Change committed as 253914

Powered by Google App Engine
This is Rietveld 408576698