Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Issue 181503003: BlendTest: implicit casts -> explicit casts (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

BlendTest: implicit casts -> explicit casts BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13595 Committed: http://code.google.com/p/skia/source/detail?r=13602

Patch Set 1 #

Patch Set 2 : ToU8 #

Patch Set 3 : another try #

Patch Set 4 : static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M tests/BlendTest.cpp View 1 2 3 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
6 years, 9 months ago (2014-02-26 16:52:16 UTC) #1
reed1
Consider SkToU8(...) -- it asserts in debug builds if the value exceeds U8 lgtm
6 years, 9 months ago (2014-02-26 16:53:10 UTC) #2
mtklein
On 2014/02/26 16:53:10, reed1 wrote: > Consider SkToU8(...) -- it asserts in debug builds if ...
6 years, 9 months ago (2014-02-26 16:55:26 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-02-26 16:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/181503003/20001
6 years, 9 months ago (2014-02-26 16:55:34 UTC) #5
commit-bot: I haz the power
Change committed as 13595
6 years, 9 months ago (2014-02-26 17:51:02 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-02-26 21:20:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/181503003/60001
6 years, 9 months ago (2014-02-26 21:20:23 UTC) #8
mtklein
On 2014/02/26 21:20:23, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 9 months ago (2014-02-26 21:21:41 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-02-26 21:40:08 UTC) #10
Message was sent while issue was closed.
Change committed as 13602

Powered by Google App Engine
This is Rietveld 408576698