Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 18150002: Set timeout before killing a process to 20 times the 30-second nag (Closed)

Created:
7 years, 5 months ago by Jói
Modified:
7 years, 5 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Set timeout before killing a process to 30 times the 30-second nag timer, i.e. ~900 seconds. This should at least help make 'fetch chromium' slightly more reliable over somewhat slow connections. BUG=230691, 247173 R=rogerta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210190

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gclient_scm.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Jói
Please see discussion of the new timeout in the bug I've linked to. Cheers, Jói
7 years, 5 months ago (2013-06-27 21:32:18 UTC) #1
Jói
Changed to 30 times the nag limit, based on latest updates in the bug. Cheers, ...
7 years, 5 months ago (2013-06-27 21:37:19 UTC) #2
Jói
ping
7 years, 5 months ago (2013-07-01 13:17:14 UTC) #3
Jói
szager -> maruel for review
7 years, 5 months ago (2013-07-02 19:42:50 UTC) #4
Jói
ping On Tue, Jul 2, 2013 at 7:42 PM, <joi@chromium.org> wrote: > szager -> maruel ...
7 years, 5 months ago (2013-07-04 10:56:30 UTC) #5
Jói
maruel@ -> rogerta@ for review as maruel@ appears to be on vacation. Cheers, Jói
7 years, 5 months ago (2013-07-04 10:59:24 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm In CL description, you say 30 times 30 seconds, or ~600 seconds. Did you ...
7 years, 5 months ago (2013-07-04 14:10:26 UTC) #7
Roger Tawa OOO till Jul 10th
On 2013/07/04 14:10:26, Roger Tawa wrote: > lgtm > > In CL description, you say ...
7 years, 5 months ago (2013-07-04 14:11:56 UTC) #8
Jói
Thanks for catching that, updated the change description to say 900. Cheers, Jói On Thu, ...
7 years, 5 months ago (2013-07-04 14:28:59 UTC) #9
Jói
Committed patchset #2 manually as r210190.
7 years, 5 months ago (2013-07-04 14:42:41 UTC) #10
iannucci
On 2013/07/04 14:42:41, Jói wrote: > Committed patchset #2 manually as r210190. Skipped the pre ...
7 years, 5 months ago (2013-07-04 20:29:12 UTC) #11
Jói
> Skipped the pre commit tests, eh? *wags finger* Sheepishly sorry :( > Tests fixed ...
7 years, 5 months ago (2013-07-04 20:33:04 UTC) #12
Jói
7 years, 5 months ago (2013-07-04 20:33:22 UTC) #13
Also, thanks for cleaning up my mess.

On Thu, Jul 4, 2013 at 8:32 PM, Jói Sigurðsson <joi@chromium.org> wrote:
>> Skipped the pre commit tests, eh? *wags finger*
>
> Sheepishly sorry :(
>
>> Tests fixed in https://codereview.chromium.org/18603010/ :)
>
> See further apologies on the review thread :)
>
> Cheers,
> Jói
>
>
> On Thu, Jul 4, 2013 at 8:29 PM,  <iannucci@chromium.org> wrote:
>> On 2013/07/04 14:42:41, Jói wrote:
>>>
>>> Committed patchset #2 manually as r210190.
>>
>>
>> Skipped the pre commit tests, eh? *wags finger*
>>
>> Tests fixed in https://codereview.chromium.org/18603010/ :)
>>
>> https://codereview.chromium.org/18150002/

Powered by Google App Engine
This is Rietveld 408576698