|
|
Created:
7 years, 5 months ago by Jói Modified:
7 years, 5 months ago Reviewers:
Roger Tawa OOO till Jul 10th CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org Visibility:
Public. |
DescriptionSet timeout before killing a process to 30 times the 30-second nag
timer, i.e. ~900 seconds.
This should at least help make 'fetch chromium' slightly more reliable
over somewhat slow connections.
BUG=230691, 247173
R=rogerta@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210190
Patch Set 1 #Patch Set 2 : #
Created: 7 years, 5 months ago
Messages
Total messages: 13 (0 generated)
Please see discussion of the new timeout in the bug I've linked to. Cheers, Jói
Changed to 30 times the nag limit, based on latest updates in the bug. Cheers, Jói
ping
szager -> maruel for review
ping On Tue, Jul 2, 2013 at 7:42 PM, <joi@chromium.org> wrote: > szager -> maruel for review > > https://codereview.chromium.org/18150002/
maruel@ -> rogerta@ for review as maruel@ appears to be on vacation. Cheers, Jói
lgtm In CL description, you say 30 times 30 seconds, or ~600 seconds. Did you mean 900 seconds, or did you really want 600 seconds?
On 2013/07/04 14:10:26, Roger Tawa wrote: > lgtm > > In CL description, you say 30 times 30 seconds, or ~600 seconds. Did you mean > 900 seconds, or did you really want 600 seconds? Oops, just noticed your comment above that the original 20 was changed to 30. I guess the CL description is out of date.
Thanks for catching that, updated the change description to say 900. Cheers, Jói On Thu, Jul 4, 2013 at 2:11 PM, <rogerta@chromium.org> wrote: > On 2013/07/04 14:10:26, Roger Tawa wrote: >> >> lgtm > > >> In CL description, you say 30 times 30 seconds, or ~600 seconds. Did you >> mean >> 900 seconds, or did you really want 600 seconds? > > > Oops, just noticed your comment above that the original 20 was changed to > 30. I > guess the CL description is out of date. > > https://codereview.chromium.org/18150002/
Message was sent while issue was closed.
Committed patchset #2 manually as r210190.
Message was sent while issue was closed.
On 2013/07/04 14:42:41, Jói wrote: > Committed patchset #2 manually as r210190. Skipped the pre commit tests, eh? *wags finger* Tests fixed in https://codereview.chromium.org/18603010/ :)
> Skipped the pre commit tests, eh? *wags finger* Sheepishly sorry :( > Tests fixed in https://codereview.chromium.org/18603010/ :) See further apologies on the review thread :) Cheers, Jói On Thu, Jul 4, 2013 at 8:29 PM, <iannucci@chromium.org> wrote: > On 2013/07/04 14:42:41, Jói wrote: >> >> Committed patchset #2 manually as r210190. > > > Skipped the pre commit tests, eh? *wags finger* > > Tests fixed in https://codereview.chromium.org/18603010/ :) > > https://codereview.chromium.org/18150002/
Also, thanks for cleaning up my mess. On Thu, Jul 4, 2013 at 8:32 PM, Jói Sigurðsson <joi@chromium.org> wrote: >> Skipped the pre commit tests, eh? *wags finger* > > Sheepishly sorry :( > >> Tests fixed in https://codereview.chromium.org/18603010/ :) > > See further apologies on the review thread :) > > Cheers, > Jói > > > On Thu, Jul 4, 2013 at 8:29 PM, <iannucci@chromium.org> wrote: >> On 2013/07/04 14:42:41, Jói wrote: >>> >>> Committed patchset #2 manually as r210190. >> >> >> Skipped the pre commit tests, eh? *wags finger* >> >> Tests fixed in https://codereview.chromium.org/18603010/ :) >> >> https://codereview.chromium.org/18150002/ |