Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1814983004: Don't create matcher functions when interpreting regex. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't create matcher functions when interpreting regex. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/27b2248f06ad6db81ffeac7b727125b977c4f722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M runtime/vm/regexp.cc View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 9 months ago (2016-03-18 20:56:59 UTC) #2
siva
lgtm
4 years, 9 months ago (2016-03-18 20:59:23 UTC) #3
rmacnak
4 years, 9 months ago (2016-03-18 21:05:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
27b2248f06ad6db81ffeac7b727125b977c4f722 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698