content/shell/browser/layout_test/blink_test_controller.cc - Issue 1814963002: Use process/control messages (instead of RVH messages) for layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/blink_test_controller.cc

Issue 1814963002: Use process/control messages (instead of RVH messages) for layout tests. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing... Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/blink_test_controller.h ('k') | content/shell/browser/layout_test/layout_test_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/blink_test_controller.cc

diff --git a/content/shell/browser/layout_test/blink_test_controller.cc b/content/shell/browser/layout_test/blink_test_controller.cc

index 5b9d1827b01c0545368c4da9f9c521e23baae861..a734843141c8cd4f13c084aa22ae831792448d64 100644

--- a/content/shell/browser/layout_test/blink_test_controller.cc

+++ b/content/shell/browser/layout_test/blink_test_controller.cc

@@ -413,7 +413,6 @@ bool BlinkTestController::OnMessageReceived(const IPC::Message& message) {

DCHECK(CalledOnValidThread());

bool handled = true;

IPC_BEGIN_MESSAGE_MAP(BlinkTestController, message)

- IPC_MESSAGE_HANDLER(ShellViewHostMsg_PrintMessage, OnPrintMessage)

IPC_MESSAGE_HANDLER(ShellViewHostMsg_TextDump, OnTextDump)

IPC_MESSAGE_HANDLER(ShellViewHostMsg_InitiateLayoutDump,

OnInitiateLayoutDump)

@@ -758,6 +757,7 @@ void BlinkTestController::OnLayoutDumpResponse(RenderFrameHost* sender,

}

void BlinkTestController::OnPrintMessage(const std::string& message) {

+ DCHECK(CalledOnValidThread());

printer_->AddMessageRaw(message);

}