Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html

Issue 181493007: Don't stop the documentLoader on navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update test expectation Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html
diff --git a/LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html b/LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html
index 703dbcc891205739ff9c500bd98c3ebe99bbc03a..fb6f3424bc6a3f247e1784651bec0287a5b2f67d 100644
--- a/LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html
+++ b/LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html
@@ -11,10 +11,11 @@ function log(text)
document.body.appendChild(document.createElement('br'));
document.body.appendChild(document.createElement('div').appendChild(document.createTextNode(text)));
}
-window.addEventListener('beforeunload', function ()
+window.addEventListener('beforeunload', function (e)
{
log('PASS');
testRunner.notifyDone();
+ e.preventDefault();
});
document.body.addEventListener('dragenter', function (event)
{
@@ -41,7 +42,6 @@ document.body.addEventListener('drop', function (event)
window.setTimeout(function ()
{
// Deadman's switch so we don't need to wait for the test to timeout to fail.
- log('FAIL');
testRunner.notifyDone();
}, 0);
})();

Powered by Google App Engine
This is Rietveld 408576698