Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@profile_manager_load
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_impl.h
diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h
index 28bbbed27fa38b6ca6a6bcfff2f43faafb0422b3..6467a4e554f60a014c4779661d1b5166631e19f3 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.h
+++ b/chrome/browser/notifications/platform_notification_service_impl.h
@@ -22,7 +22,6 @@
#include "content/public/common/persistent_notification_status.h"
class NotificationDelegate;
-class NotificationUIManager;
namespace content {
class BrowserContext;
@@ -77,10 +76,6 @@ class PlatformNotificationServiceImpl
const GURL& origin,
bool by_user);
- // Returns the Notification UI Manager through which notifications can be
- // displayed to the user. Can be overridden for testing.
- NotificationUIManager* GetNotificationUIManager() const;
-
// Open the Notification settings screen when clicking the right button.
void OpenNotificationSettings(content::BrowserContext* browser_context);
@@ -136,20 +131,10 @@ class PlatformNotificationServiceImpl
const content::NotificationResources& notification_resources,
NotificationDelegate* delegate) const;
- // Overrides the Notification UI Manager to use to |manager|. Only to be
- // used by tests. Tests are responsible for cleaning up after themselves.
- void SetNotificationUIManagerForTesting(NotificationUIManager* manager);
-
// Returns a display name for an origin, to be used in the context message
base::string16 DisplayNameForContextMessage(Profile* profile,
const GURL& origin) const;
- // Platforms that display native notification interact with them through this
- // object.
- scoped_ptr<NotificationUIManager> native_notification_ui_manager_;
-
- // Weak reference. Ownership maintains with the test.
- NotificationUIManager* notification_ui_manager_for_tests_;
// Mapping between a persistent notification id and the id of the associated
// message_center::Notification object. Must only be used on the UI thread.

Powered by Google App Engine
This is Rietveld 408576698