Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2099)

Unified Diff: chrome/browser/notifications/notification_bridge.h

Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@profile_manager_load
Patch Set: Review comments + unique_ptr rename Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_bridge.h
diff --git a/chrome/browser/notifications/notification_bridge.h b/chrome/browser/notifications/notification_bridge.h
new file mode 100644
index 0000000000000000000000000000000000000000..41d8cf2d2ebabe779e6227f04b09c9b202c92dc8
--- /dev/null
+++ b/chrome/browser/notifications/notification_bridge.h
@@ -0,0 +1,58 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_BRIDGE_H_
+#define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_BRIDGE_H_
+
+#include <set>
+#include <string>
+
+#include "base/macros.h"
+
+class Notification;
+
+// Provides the low-level interface that enables notifications to be displayed
+// and interacted with on the user's screen, orthogonal of whether this
+// functionality is provided by the browser or by the operating system.
+// TODO(miguelg): Add support for click and close events.
+class NotificationBridge {
Peter Beverloo 2016/04/20 17:34:08 Sorry for the bike-shedding, but what do you think
+ public:
+ static NotificationBridge* Create();
+
+ virtual ~NotificationBridge() {}
+
+ // Shows a toast on screen using the data passed in |notification|.
+ virtual void Display(const std::string& notification_id,
+ const std::string& profile_id,
+ bool is_incognito,
+ const Notification& notification) = 0;
+
+ // Closes a nofication with |notification_id| and |profile_id| if being
+ // displayed.
+ virtual void Close(const std::string& profile_id,
+ const std::string& notification_id) = 0;
+
+ // Fills in |notifications| with a set of notification ids currently being
+ // displayed for a given profile.
+ // The return value expresses whether the underlying platform has the
+ // capability to provide displayed notifications so the empty set
+ // can be disambiguated.
+ virtual bool GetDisplayed(const std::string& profile_id,
+ bool incognito,
+ std::set<std::string>* notification_ids) const = 0;
+
+ // Temporary method while the refactor is finished. It denotes whether
+ // the notifications will be shown by chrome itself or by the OS.
+ // It is needed while migrating MacOSX and Windows to their respective
+ // notification centers since the decision is made at runtime via flags.
+ virtual bool SupportsNotificationCenter() const = 0;
+
+ protected:
+ NotificationBridge() {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(NotificationBridge);
+};
+
+#endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_BRIDGE_H_

Powered by Google App Engine
This is Rietveld 408576698