chrome/browser/browser_process_impl.h - Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_process_impl.h

Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@profile_manager_load

Patch Set: Review comments + unique_ptr rename Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_process_impl.h

diff --git a/chrome/browser/browser_process_impl.h b/chrome/browser/browser_process_impl.h

index e4a287d6ef024fc203b22ec45a6655295b3ba803..400ef481e5f9e2f18fb4513b9b93d87eb72c928f 100644

--- a/chrome/browser/browser_process_impl.h

+++ b/chrome/browser/browser_process_impl.h

@@ -107,6 +107,7 @@ class BrowserProcessImpl : public BrowserProcess,

BrowserProcessPlatformPart* platform_part() override;

extensions::EventRouterForwarder* extension_event_router_forwarder() override;

NotificationUIManager* notification_ui_manager() override;

+ NotificationBridge* notification_bridge() override;

message_center::MessageCenter* message_center() override;

policy::BrowserPolicyConnector* browser_policy_connector() override;

policy::PolicyService* policy_service() override;

@@ -169,6 +170,7 @@ class BrowserProcessImpl : public BrowserProcess,

void CreateViewedPageTracker();

void CreateIconManager();

void CreateIntranetRedirectDetector();

+ void CreateNotificationBridge();

void CreateNotificationUIManager();

void CreateStatusTrayManager();

void CreatePrintPreviewDialogController();

@@ -246,6 +248,9 @@ class BrowserProcessImpl : public BrowserProcess,

std::unique_ptr<StatusTray> status_tray_;

+ bool created_notification_bridge_;

+ std::unique_ptr<NotificationBridge> notification_bridge_;

#if BUILDFLAG(ENABLE_BACKGROUND)

std::unique_ptr<BackgroundModeManager> background_mode_manager_;

#endif

« no previous file with comments | « chrome/browser/browser_process.h ('k') | chrome/browser/browser_process_impl.cc » ('j') | chrome/browser/browser_process_impl.cc » ('J')