chrome/browser/android/chrome_jni_registrar.cc - Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_jni_registrar.cc

Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@profile_manager_load

Patch Set: Review comments + unique_ptr rename Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java ('k') | chrome/browser/browser_process.h » ('j') | chrome/browser/browser_process_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/chrome_jni_registrar.cc

diff --git a/chrome/browser/android/chrome_jni_registrar.cc b/chrome/browser/android/chrome_jni_registrar.cc

index cc3ce9076bdbed694b9c7a48c4787da9dfab9d28..3d30a068898c4dab300620132feace2235654787 100644

--- a/chrome/browser/android/chrome_jni_registrar.cc

+++ b/chrome/browser/android/chrome_jni_registrar.cc

@@ -312,7 +312,7 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {

RegisterExternalEstimateProviderAndroid},

{"NewTabPagePrefs", NewTabPagePrefs::RegisterNewTabPagePrefs},

{"NotificationUIManager",

- NotificationUIManagerAndroid::RegisterNotificationUIManager},

+ NotificationUIManagerAndroid::RegisterNotificationBridge},

{"NTPSnippetsBridge", NTPSnippetsBridge::Register},

{"NTPSnippetsLauncher", NTPSnippetsLauncher::Register},

{"OAuth2TokenServiceDelegateAndroid",