Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4615)

Unified Diff: chrome/test/base/testing_browser_process.cc

Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@profile_manager_load
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/testing_browser_process.cc
diff --git a/chrome/test/base/testing_browser_process.cc b/chrome/test/base/testing_browser_process.cc
index 113217feaccebb99d3f4fbf81487e93d46e7d220..ca483c9ae02cc9a613d55b39d3526835fd49196a 100644
--- a/chrome/test/base/testing_browser_process.cc
+++ b/chrome/test/base/testing_browser_process.cc
@@ -214,6 +214,10 @@ TestingBrowserProcess::extension_event_router_forwarder() {
}
NotificationUIManager* TestingBrowserProcess::notification_ui_manager() {
+#if defined(OS_ANDROID)
Peter Beverloo 2016/04/18 14:57:10 Why not modify the #ifdef on line 221? Displaying
Miguel Garcia 2016/04/19 14:24:58 SG
+ return nullptr;
+#endif
+
#if defined(ENABLE_NOTIFICATIONS)
if (!notification_ui_manager_.get())
notification_ui_manager_.reset(
@@ -225,6 +229,10 @@ NotificationUIManager* TestingBrowserProcess::notification_ui_manager() {
#endif
}
+NotificationBridge* TestingBrowserProcess::notification_bridge() {
+ return nullptr;
+}
+
message_center::MessageCenter* TestingBrowserProcess::message_center() {
return message_center::MessageCenter::Get();
}

Powered by Google App Engine
This is Rietveld 408576698