chrome/chrome_browser.gypi - Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@profile_manager_load

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/platform_notification_service_impl.cc ('K') | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | chrome/test/base/testing_browser_process.h » ('j') | chrome/test/base/testing_browser_process.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index dc9cb13465fa3f9803a0d235d13b960390481da0..ccd865e62f9ad825c1375c2cb44465e5e4546eca 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -2148,13 +2148,20 @@

# Used on all platforms when notifications are enabled.

'chrome_browser_notifications_sources': [

+ 'browser/notifications/chrome_notification_display_service.cc',

+ 'browser/notifications/chrome_notification_display_service.h',

'browser/notifications/desktop_notification_profile_util.cc',

'browser/notifications/desktop_notification_profile_util.h',

'browser/notifications/login_state_notification_blocker_chromeos.cc',

'browser/notifications/login_state_notification_blocker_chromeos.h',

+ 'browser/notifications/native_notification_display_service.cc',

+ 'browser/notifications/native_notification_display_service.h',

'browser/notifications/notification.cc',

'browser/notifications/notification.h',

'browser/notifications/notification_delegate.h',

+ 'browser/notifications/notification_display_service.h',

+ 'browser/notifications/notification_display_service_factory.cc',

+ 'browser/notifications/notification_display_service_factory.h',

'browser/notifications/notification_object_proxy.cc',

'browser/notifications/notification_object_proxy.h',

'browser/notifications/notification_permission_context.cc',