Nuke NotificationUIManager from PlatformNotificationServiceImpl

chrome/browser/notifications/notification_display_service.h

Index: chrome/browser/notifications/notification_display_service.h
diff --git a/chrome/browser/notifications/notification_display_service.h b/chrome/browser/notifications/notification_display_service.h
new file mode 100644
index 0000000000000000000000000000000000000000..dc37be01cb354a5584b984a72ffd9d048f537d56
--- /dev/null
+++ b/chrome/browser/notifications/notification_display_service.h
@@ -0,0 +1,47 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_
+#define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_
+
+#include <set>
+#include <string>
+#include "base/macros.h"
+#include "components/keyed_service/core/keyed_service.h"
+
+class Notification;
+class NotificationBridge;
+class Profile;
+
+// A class to display and interact with notifications in the different
+// notification centers.

[Peter Beverloo, 2016/04/18 14:57:09]

// Profile-bound service that enables notifications to be displayed and
// interacted with on the user's screen, orthogonal of whether this
// functionality is provided by the browser or by the operating system. An
// instance can be retrieved through the NotificationDisplayServiceFactory.
//
// TODO(peter): Add a NotificationHandler mechanism for registering listeners.
// TODO(miguelg): Remove the SupportsNotificationCenter method.

[Miguel Garcia, 2016/04/19 14:24:57]

Done.

+class NotificationDisplayService : public KeyedService {
+ public:
+  NotificationDisplayService() {}
+  ~NotificationDisplayService() override {}
+
+  // Shows a toast on string using the data passed in |notification|.

[Peter Beverloo, 2016/04/18 14:57:09]

// Displays the |notification| identified by |notification_id|.

Is there any sensible way we can provide guarantees about whether it actually
happened, i.e. have this return a bool (or a callback)?

[Miguel Garcia, 2016/04/19 14:24:57]

Not on mac (nor Android I think).If Windows offers it we could add it later.

+  virtual void Display(const std::string& notification_id,
+                       const Notification& notification) = 0;
+
+  // Closes a notification.

[Peter Beverloo, 2016/04/18 14:57:09]

// Closes the notification identified by |notification_id|.

[Miguel Garcia, 2016/04/19 14:24:57]

Done.

+  virtual void Close(const std::string& notification_id) = 0;
+
+  // Fills in |notifications| with a set of notification ids currently being
+  // displayed either as popups or in the native platform's notification
+  // center.
+  // The return value expresses whether the underlying platform has the
+  // capability to provide displayed notifications so the empty set
+  // can be disambiguated.

[Peter Beverloo, 2016/04/18 14:57:09]

  // Returns whether the implementation can retrieve a list of currently visible
  // notifications and stores them in |*notification_ids| when possible.

[Miguel Garcia, 2016/04/19 14:24:57]

Done.

+  virtual bool GetDisplayed(std::set<std::string>* notifications) const = 0;
+
+  // Temporary method while we finish the refactor. Returns whether there is
+  // a native notification center backing up notifications.
+  virtual bool SupportsNotificationCenter() const = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(NotificationDisplayService);
+};
+
+#endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_