chrome/browser/browser_process.h - Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_process.h

Issue 1814923002: Nuke NotificationUIManager from PlatformNotificationServiceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@profile_manager_load

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/browser_process_impl.h » ('j') | chrome/browser/notifications/chrome_notification_display_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browser_process.h

diff --git a/chrome/browser/browser_process.h b/chrome/browser/browser_process.h

index 540ba2a4de4aace6afd5160c2185b67ee104c328..3d06ace04417ee2f5024b401dd11107028d43c98 100644

--- a/chrome/browser/browser_process.h

+++ b/chrome/browser/browser_process.h

@@ -30,6 +30,7 @@ class IconManager;

class IntranetRedirectDetector;

class IOThread;

class MediaFileSystemRegistry;

+class NotificationBridge;

class NotificationUIManager;

class PrefRegistrySimple;

class PrefService;

@@ -150,7 +151,10 @@ class BrowserProcess {

extension_event_router_forwarder() = 0;

// Returns the manager for desktop notifications.

+ // TODO(miguelg) This is in the process of being deprecated in favour of

+ // NotificationBridge + NotificationDisplayService

virtual NotificationUIManager* notification_ui_manager() = 0;

+ virtual NotificationBridge* notification_bridge() = 0;

// MessageCenter is a global list of currently displayed notifications.

virtual message_center::MessageCenter* message_center() = 0;