Nuke NotificationUIManager from PlatformNotificationServiceImpl

chrome/browser/notifications/notification_display_service_factory.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/notifications/notification_display_service_factory.h"
+
+#include "base/command_line.h"
+#include "base/memory/singleton.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/notifications/message_center_display_service.h"
+#include "chrome/browser/notifications/notification_ui_manager.h"
+#include "chrome/browser/profiles/incognito_helpers.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/chrome_switches.h"
+#include "components/keyed_service/content/browser_context_dependency_manager.h"
+
+#if defined(OS_ANDROID) || defined(OS_MACOSX)
+#include "chrome/browser/notifications/native_notification_display_service.h"
+#endif
+
+// static
+NotificationDisplayService* NotificationDisplayServiceFactory::GetForProfile(
+    Profile* profile) {
+  return static_cast<NotificationDisplayService*>(
+      GetInstance()->GetServiceForBrowserContext(profile, true /* create */));
+}
+
+// static
+NotificationDisplayServiceFactory*
+NotificationDisplayServiceFactory::GetInstance() {
+  return base::Singleton<NotificationDisplayServiceFactory>::get();
+}
+
+NotificationDisplayServiceFactory::NotificationDisplayServiceFactory()
+    : BrowserContextKeyedServiceFactory(
+          "NotificationDisplayService",
+          BrowserContextDependencyManager::GetInstance()) {}
+
+// Android always uses the native service
+// MAC uses the native manager if chrome://flags#enable-native-notifications is
+// toggled
+// Everything else uses the chrome service

[Peter Beverloo, 2016/04/20 17:34:08]

nit: I would phrase this as follows:

// Selection of the implementation works as follows:
//   - Android always uses the NativeNotificationDisplayService.
//   - Mac uses the MessageCenterDisplayService by default, but can use the
//     NativeNotificationDisplayService by using the chrome://flags or the
//     --enable-native-notifications command line flag.
//   - All other platforms always use the MessageCenterDisplayService.

[Miguel Garcia, 2016/04/21 14:32:10]

Done.

+KeyedService* NotificationDisplayServiceFactory::BuildServiceInstanceFor(
+    content::BrowserContext* context) const {
+#if defined(OS_ANDROID)
+  return new NativeNotificationDisplayService(
+      Profile::FromBrowserContext(context),
+      g_browser_process->notification_bridge());
+#elif defined(OS_MACOSX)
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableNativeNotifications)) {
+    return new NativeNotificationDisplayService(
+        Profile::FromBrowserContext(context),
+        g_browser_process->notification_bridge());
+  }
+#endif
+  return new MessageCenterDisplayService(
+      Profile::FromBrowserContext(context),
+      g_browser_process->notification_ui_manager());
+}
+
+content::BrowserContext*
+NotificationDisplayServiceFactory::GetBrowserContextToUse(
+    content::BrowserContext* context) const {
+  return chrome::GetBrowserContextOwnInstanceInIncognito(context);
+}