Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1814893002: Issue 25945. Include static/propagateInvokeType for MethodInvocation names into hover. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 25945. Include static/propagateInvokeType for MethodInvocation names into hover. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/25945 Committed: https://github.com/dart-lang/sdk/commit/c0d40223bf8bdd5a0e94d3eaf271935fc8361b89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 2 chunks +20 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_hover_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-17 17:23:54 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-17 17:27:32 UTC) #2
scheglov
4 years, 9 months ago (2016-03-17 17:29:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0d40223bf8bdd5a0e94d3eaf271935fc8361b89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698