components/autofill/core/browser/autofill_manager_unittest.cc - Issue 1814883002: [Autofill] Check for full state name and abbreviation when determining types to upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager_unittest.cc

Issue 1814883002: [Autofill] Check for full state name and abbreviation when determining types to upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/address.cc ('K') | « components/autofill/core/browser/autofill_field.cc ('k') | components/autofill/core/browser/autofill_profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager_unittest.cc

diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc

index f8e9772e0a8d30e4656f067e3f13c240154178aa..cf3d96508e4731f6648d2c34cf0edff520d350dd 100644

--- a/components/autofill/core/browser/autofill_manager_unittest.cc

+++ b/components/autofill/core/browser/autofill_manager_unittest.cc

@@ -3326,7 +3326,7 @@ TEST_F(AutofillManagerTest, DeterminePossibleFieldTypesForUpload) {

profile.set_guid("00000000-0000-0000-0000-000000000001");

profiles.push_back(profile);

test::SetProfileInfo(&profile, "Charles", "", "Holley", "buddy@gmail.com",

- "Decca", "123 Apple St.", "unit 6", "Lubbock", "Texas",

+ "Decca", "123 Apple St.", "unit 6", "Lubbock", "TX",

"79401", "US", "5142821292");

profile.set_guid("00000000-0000-0000-0000-000000000002");

profiles.push_back(profile);

@@ -3413,6 +3413,10 @@ TEST_F(AutofillManagerTest, DeterminePossibleFieldTypesForUpload) {

{"3734 Elvis Presley Blvd", ADDRESS_HOME_LINE1},

{"3734, Elvis Presley Blvd.", ADDRESS_HOME_LINE1},

+ // Make sure that a state's full name and abbreviation match.

+ {"TN", ADDRESS_HOME_STATE}, // Saved as "Tennessee" in profile.

+ {"Texas", ADDRESS_HOME_STATE}, // Saved as "TX" in profile.

// Special phone number case. A profile with no country code should only

// match PHONE_HOME_CITY_AND_NUMBER.

{"5142821292", PHONE_HOME_CITY_AND_NUMBER},

@@ -3421,7 +3425,6 @@ TEST_F(AutofillManagerTest, DeterminePossibleFieldTypesForUpload) {

{"Elvis Aaron", UNKNOWN_TYPE},

{"Mr. Presley", UNKNOWN_TYPE},

{"3734 Elvis Presley", UNKNOWN_TYPE},

- {"TN", UNKNOWN_TYPE},

{"38116-1023", UNKNOWN_TYPE},

{"5", UNKNOWN_TYPE},

{"56", UNKNOWN_TYPE},