Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1814863005: Pass all parser flags from Parser to PreParser (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@turn-off-legacy-const
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass all parser flags from Parser to PreParser This revealed one Mozilla test that depended upon a lack of early error for "with ({}) function ...". The test has been marked as failing. R=littledan@chromium.org Committed: https://crrev.com/3c5d6caac288feda37cff568acede2ed0bfdaa92 Cr-Commit-Position: refs/heads/master@{#34910}

Patch Set 1 #

Patch Set 2 : Mark a mozilla test as failing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/parsing/parser.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/mozilla/mozilla.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
adamk
4 years, 9 months ago (2016-03-18 00:08:45 UTC) #1
adamk
Tests should now pass, as a bonus.
4 years, 9 months ago (2016-03-18 23:13:38 UTC) #3
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-18 23:41:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814863005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814863005/20001
4 years, 9 months ago (2016-03-19 00:35:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-19 00:53:39 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 00:55:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c5d6caac288feda37cff568acede2ed0bfdaa92
Cr-Commit-Position: refs/heads/master@{#34910}

Powered by Google App Engine
This is Rietveld 408576698