Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2603)

Unified Diff: sandbox/win/src/address_sanitizer_test.cc

Issue 1814863004: Cleanup/Remove Windows XP/Vista version checks from Windows sandbox code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert disabled reparse point check Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/src/Wow64_64.cc ('k') | sandbox/win/src/broker_services.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/address_sanitizer_test.cc
diff --git a/sandbox/win/src/address_sanitizer_test.cc b/sandbox/win/src/address_sanitizer_test.cc
index b4be8bcf7a8850d2df1d1efb699d6fee95299167..a18cab7ab62fc5bd8fac5e34dad58c14348d81ef 100644
--- a/sandbox/win/src/address_sanitizer_test.cc
+++ b/sandbox/win/src/address_sanitizer_test.cc
@@ -88,17 +88,13 @@ TEST_F(AddressSanitizerTests, TestAddressSanitizer) {
std::string data;
ASSERT_TRUE(base::ReadFileToString(base::FilePath(temp_file_name), &data));
// Redirection uses a feature that was added in Windows Vista.
- if (base::win::GetVersion() >= base::win::VERSION_VISTA) {
- ASSERT_TRUE(
- strstr(data.c_str(), "ERROR: AddressSanitizer: heap-buffer-overflow"))
- << "There doesn't seem to be an ASan report:\n" << data;
- ASSERT_TRUE(strstr(data.c_str(), "AddressSanitizerTests_Report"))
- << "The ASan report doesn't appear to be symbolized:\n" << data;
- ASSERT_TRUE(strstr(data.c_str(), strrchr(__FILE__, '\\')))
- << "The stack trace doesn't have a correct filename:\n" << data;
- } else {
- LOG(WARNING) << "Pre-Vista versions are not supported.";
- }
+ ASSERT_TRUE(
+ strstr(data.c_str(), "ERROR: AddressSanitizer: heap-buffer-overflow"))
+ << "There doesn't seem to be an ASan report:\n" << data;
+ ASSERT_TRUE(strstr(data.c_str(), "AddressSanitizerTests_Report"))
+ << "The ASan report doesn't appear to be symbolized:\n" << data;
+ ASSERT_TRUE(strstr(data.c_str(), strrchr(__FILE__, '\\')))
+ << "The stack trace doesn't have a correct filename:\n" << data;
} else {
LOG(WARNING) << "Not an AddressSanitizer build, skipping the run.";
}
« no previous file with comments | « sandbox/win/src/Wow64_64.cc ('k') | sandbox/win/src/broker_services.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698