third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 1814863002: Make page popups work under OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index 8a68f34e5008f8454667a4ed92dd5f63a2625b2b..056a6cd37ad1c9057d84bafee661b683816eafee 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -94,7 +94,7 @@ public:

IntRect windowResizerRect() const override;

void invalidateRect(const IntRect&) override;

void scheduleAnimation(Widget*) override;

- IntRect viewportToScreen(const IntRect&) const override;

+ IntRect viewportToScreen(const IntRect&, const Widget*) const override;

float windowToViewportScalar(const float) const override;

WebScreenInfo screenInfo() const override;

void contentsSizeChanged(LocalFrame*, const IntSize&) const override;