third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 1814863002: Make page popups work under OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: WebContentsImpl::SendScreenRects simplified Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index 6dd54001587b8793c2427a3817dc2ad4c4f751d5..a4f382cea478e2a993e03c2d100f24fb761f281c 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -2896,7 +2896,7 @@ WebInputEventResult EventHandler::sendContextMenuEventForKey(Element* overrideTa

m_frame->view()->setCursor(pointerCursor());

IntPoint locationInViewport = visualViewport.rootFrameToViewport(locationInRootFrame);

- IntPoint globalPosition = view->hostWindow()->viewportToScreen(IntRect(locationInViewport, IntSize())).location();

+ IntPoint globalPosition = view->hostWindow()->viewportToScreen(IntRect(locationInViewport, IntSize()), m_frame->view()).location();

Node* targetNode = overrideTargetElement ? overrideTargetElement : doc->focusedElement();

if (!targetNode)