content/browser/web_contents/web_contents_impl.cc - Issue 1814863002: Make page popups work under OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabled test on Mac Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 0a748f1078548df692d61e70b33952ee0b2ec6dc..95eba77b507f81624165d512bcd98eeed94666e2 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2226,8 +2226,10 @@ void WebContentsImpl::OnMoveValidationMessage(

}

void WebContentsImpl::SendScreenRects() {

- RenderWidgetHostImpl::From(GetRenderViewHost()->GetWidget())

- ->SendScreenRects();

+ for (FrameTreeNode* node : frame_tree_.Nodes()) {

+ if (node->current_frame_host()->GetRenderWidgetHost())

+ node->current_frame_host()->GetRenderWidgetHost()->SendScreenRects();

+ }

RenderWidgetHostViewBase* rwhv =

static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());