content/browser/renderer_host/render_view_host_impl.cc - Issue 1814863002: Make page popups work under OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabled test on Mac Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 173b4eda6757090736e4a38d275f82744a84106a..a0a7f6ff869862878e5ded891e03e78eb733b256 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -978,8 +978,7 @@ void RenderViewHostImpl::OnShowView(int route_id,

void RenderViewHostImpl::OnShowWidget(int route_id,

const gfx::Rect& initial_rect) {

- if (is_active_)

- delegate_->ShowCreatedWidget(route_id, initial_rect);

+ delegate_->ShowCreatedWidget(route_id, initial_rect);

Send(new ViewMsg_Move_ACK(route_id));

}