Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled test on Mac Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/cross_process_frame_connector.cc
diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc
index de0b5d3b2f9d0a2f7b52a3da84e594e60136bd11..649f4a2b8c61856c9dd165fa843fcd04e8e8c2c0 100644
--- a/content/browser/frame_host/cross_process_frame_connector.cc
+++ b/content/browser/frame_host/cross_process_frame_connector.cc
@@ -63,7 +63,7 @@ void CrossProcessFrameConnector::set_view(
if (view_) {
view_->set_cross_process_frame_connector(this);
SetDeviceScaleFactor(device_scale_factor_);
- SetSize(child_frame_rect_);
+ SetRect(child_frame_rect_);
}
}
@@ -108,7 +108,7 @@ void CrossProcessFrameConnector::OnInitializeChildFrame(gfx::Rect frame_rect,
SetDeviceScaleFactor(scale_factor);
if (!frame_rect.size().IsEmpty())
- SetSize(frame_rect);
+ SetRect(frame_rect);
}
gfx::Rect CrossProcessFrameConnector::ChildFrameRect() {
@@ -210,7 +210,7 @@ void CrossProcessFrameConnector::OnForwardInputEvent(
void CrossProcessFrameConnector::OnFrameRectChanged(
const gfx::Rect& frame_rect) {
if (!frame_rect.size().IsEmpty())
- SetSize(frame_rect);
+ SetRect(frame_rect);
}
void CrossProcessFrameConnector::OnVisibilityChanged(bool visible) {
@@ -246,10 +246,10 @@ void CrossProcessFrameConnector::SetDeviceScaleFactor(float scale_factor) {
}
}
-void CrossProcessFrameConnector::SetSize(gfx::Rect frame_rect) {
+void CrossProcessFrameConnector::SetRect(const gfx::Rect& frame_rect) {
child_frame_rect_ = frame_rect;
if (view_)
- view_->SetSize(frame_rect.size());
+ view_->SetBounds(frame_rect);
}
RenderWidgetHostViewBase*

Powered by Google App Engine
This is Rietveld 408576698