Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1814853005: Restructure/fix thread pointer visiting; added some asserts. (Closed)

Created:
4 years, 9 months ago by srdjan
Modified:
4 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restructure/fix thread pointer visiting; added some asserts. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/dda658f48a3d407f01b914395e2b6a869ec73ce1

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M runtime/vm/isolate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread.cc View 2 chunks +15 lines, -1 line 0 comments Download
M runtime/vm/thread_registry.cc View 1 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 9 months ago (2016-03-17 19:56:19 UTC) #2
siva
lgtm
4 years, 9 months ago (2016-03-17 20:17:30 UTC) #3
srdjan
4 years, 9 months ago (2016-03-17 20:25:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dda658f48a3d407f01b914395e2b6a869ec73ce1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698