third_party/WebKit/Source/core/html/HTMLScriptElement.h - Issue 1814853003: Track whether an element was inserted via document.write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLScriptElement.h

Issue 1814853003: Track whether an element was inserted via document.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: back to ps2 with some changes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp ('k') | third_party/WebKit/Source/core/html/HTMLScriptElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLScriptElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLScriptElement.h b/third_party/WebKit/Source/core/html/HTMLScriptElement.h

index 1d1dcae44f1b984ed57ea6990047b2092742777f..73d445d6a74e0427f104a464e5883b369b825e09 100644

--- a/third_party/WebKit/Source/core/html/HTMLScriptElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLScriptElement.h

@@ -34,7 +34,7 @@ namespace blink {

class CORE_EXPORT HTMLScriptElement final : public HTMLElement, public ScriptLoaderClient {

DEFINE_WRAPPERTYPEINFO();

public:

- static RawPtr<HTMLScriptElement> create(Document&, bool wasInsertedByParser, bool alreadyStarted = false);

+ static RawPtr<HTMLScriptElement> create(Document&, bool wasInsertedByParser, bool alreadyStarted = false, bool createdDuringDocumentWrite = false);

String text() { return textFromChildren(); }

void setText(const String&);

@@ -49,7 +49,7 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- HTMLScriptElement(Document&, bool wasInsertedByParser, bool alreadyStarted);

+ HTMLScriptElement(Document&, bool wasInsertedByParser, bool alreadyStarted, bool createdDuringDocumentWrite);

void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;

InsertionNotificationRequest insertedInto(ContainerNode*) override;